[fix] #5 RequestDto Builder 패턴 삭제 및 커스텀 에러 핸들링 추가

Wedit-project · Jan 18, 2025 · 39e3b18 · 39e3b18
1 parent 88e30ea
commit 39e3b18
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/src/main/java/com/wedit/weditapp/domain/member/domain/Member.java b/src/main/java/com/wedit/weditapp/domain/member/domain/Member.java
@@ -3,6 +3,8 @@
 import com.wedit.weditapp.domain.shared.BaseTimeEntity;
 import com.wedit.weditapp.domain.shared.MemberRole;
 import com.wedit.weditapp.domain.shared.MemberStatus;
+import com.wedit.weditapp.global.error.ErrorCode;
+import com.wedit.weditapp.global.error.exception.CommonException;
 import jakarta.persistence.*;
 import lombok.AccessLevel;
 import lombok.Builder;
@@ -53,15 +55,15 @@ public static Member createUser(String email, String name) {
     // 사용자 이메일 변경 Method
     public void updateEmail(String newEmail) {
         if (newEmail == null || newEmail.trim().isEmpty()) {
-            throw new IllegalArgumentException("공백이면 안됩니다.");
+            throw new CommonException(ErrorCode.EMPTY_FIELD);
         }
-        this.name = newEmail;
+        this.email = newEmail;
     }
 
     // 사용자 이름 변경 Method
     public void updateName(String newName) {
         if (newName == null || newName.trim().isEmpty()) {
-            throw new IllegalArgumentException("공백이면 안됩니다.");
+            throw new CommonException(ErrorCode.EMPTY_FIELD);
         }
         this.name = newName;
     }
@@ -74,7 +76,7 @@ public void deactivate() {
     // 사용자 역할 변경 Method
     public void updateRole(MemberRole newRole) {
         if (newRole == null) {
-            throw new IllegalArgumentException("공백이면 안됩니다.");
+            throw new CommonException(ErrorCode.EMPTY_FIELD);
         }
         this.role = newRole;
     }

diff --git a/src/main/java/com/wedit/weditapp/domain/member/dto/LoginRequestDto.java b/src/main/java/com/wedit/weditapp/domain/member/dto/LoginRequestDto.java
@@ -9,8 +9,4 @@
 public class LoginRequestDto {
     private String email;
 
-    @Builder
-    public LoginRequestDto(String email) {
-        this.email = email;
-    }
 }
diff --git a/src/main/java/com/wedit/weditapp/domain/member/dto/MemberRequestDto.java b/src/main/java/com/wedit/weditapp/domain/member/dto/MemberRequestDto.java
@@ -16,10 +16,4 @@ public class MemberRequestDto {
 
     @NotBlank(message = "이름을 반드시 입력해야 합니다.")
     private String name;
-
-    @Builder
-    public MemberRequestDto(String email, String name) {
-        this.email = email;
-        this.name = name;
-    }
 }
diff --git a/src/main/java/com/wedit/weditapp/global/error/ErrorCode.java b/src/main/java/com/wedit/weditapp/global/error/ErrorCode.java
@@ -14,6 +14,7 @@ public enum ErrorCode {
 	INVALID_FILE_FORMAT(400, "INVALID_FILE_FORMAT", "올바르지 않은 파일 형식입니다."),
 	INVALID_TOKEN(401, "INVALID_TOKEN",  "유효하지 않은 토큰입니다."),
 	REJECT_DUPLICATION(409, "REJECT_DUPLICATION", "중복된 값입니다."),
+	EMPTY_FIELD(400, "EMPTY_FIELD", "공백이면 안됩니다."),
 
 	//회원
 	LOGIN_FAIL(401, "LOGIN_FAIL", "로그인에 실패하였습니다."),