Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
…ount, URL 부분 제외)
dyk-im
requested changes
Jan 21, 2025
...ain/java/com/wedit/weditapp/domain/bankAccounts/domain/repository/BankAccountRepository.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Getter | ||
| @NoArgsConstructor | ||
| public class BankAccountDTO { |
There was a problem hiding this comment.
Request와 Response가 명확하도록 dto 명을 수정해주시면 좋겠습니다!
There was a problem hiding this comment.
청첩장 등록과 조회 모두에서 같은 dto를 사용할 예정인데 나눠서 만들어야 하는지 궁금합니다!
There was a problem hiding this comment.
요청과 응답이 동일하다면 동일하게 사용해도 괜찮을 것 같습니다!
src/main/java/com/wedit/weditapp/domain/image/domain/Image.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wedit/weditapp/domain/invitation/controller/InvitationController.java
Show resolved
Hide resolved
src/main/java/com/wedit/weditapp/domain/invitation/dto/request/InvitationUpdateRequestDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wedit/weditapp/domain/invitation/dto/response/InvitationResponseDTO.java
Show resolved
Hide resolved
src/main/java/com/wedit/weditapp/domain/invitation/service/InvitationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wedit/weditapp/domain/invitation/service/InvitationService.java
Outdated
Show resolved
Hide resolved
dogsub
approved these changes
Jan 22, 2025
src/main/java/com/wedit/weditapp/domain/invitation/controller/InvitationController.java
Show resolved
Hide resolved
KyunghwanChoi
approved these changes
Jan 22, 2025
| @Column(nullable = false) | ||
| private int location; | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.REMOVE) // 초대장 삭제 시 이미지도 삭제 |
There was a problem hiding this comment.
Cascade REMOVE 옵션을 새롭게 알게됐습니다!
Comments, Decisions 엔티티도 이에 맞게 수정해보겠습니다.
수고 많으셨습니다!
dyk-im
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📣 To Reviewers
member 쪽 미완성으로, 우선 MemberID를 Pathvariable로 받아와서 테스트 했습니다.
이 부분은 모든 api 완성 후 한 번에 처리할 예정입니다.
url로 반환하는 부분도 추후에 추가 예정입니다.
예외처리도 한 번에 처리할 에정입니다.