-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 청첩장 조회 API #34
Merged
The head ref may contain hidden characters: "feat/#27-\uCCAD\uCCA9\uC7A5-\uC870\uD68C-API2"
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
46151ca
[refactor] #27 - errorcode 수정
leeseulgi0208 70a32c4
[refactor] #27 - bankaccountRepo 수정
leeseulgi0208 0b2adb3
[feat] #27 - bankaccountservice에 getBankaccount 생성
leeseulgi0208 0c0740f
[feat] #27 - InvitationService에 getInvitation 생성
leeseulgi0208 7b0d981
InvitationController에 청첩장 조회 생성
leeseulgi0208 78d7f75
[feat] #27 - image 부분 추가
leeseulgi0208 b9eb753
[fix] #27 - DTO 서버 에러 수정
leeseulgi0208 a9ec774
[refactor] #27 - 불필요한 import 제거
leeseulgi0208 f67e585
[refactor] #27 - responseDto 유효성 검사 부분 삭제, DTO->Dto로 수정
leeseulgi0208 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 4 additions & 1 deletion
5
.../java/com/wedit/weditapp/domain/bankAccounts/domain/repository/BankAccountRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
package com.wedit.weditapp.domain.bankAccounts.domain.repository; | ||
|
||
import java.util.List; | ||
|
||
import org.springframework.data.jpa.repository.JpaRepository; | ||
import com.wedit.weditapp.domain.bankAccounts.domain.BankAccounts; | ||
import com.wedit.weditapp.domain.invitation.domain.Invitation; | ||
|
||
public interface BankAccountRepository extends JpaRepository<BankAccounts, Long> { | ||
List<BankAccounts> findByInvitation(Invitation invitation); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/main/java/com/wedit/weditapp/domain/image/dto/response/ImageResponseDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.wedit.weditapp.domain.image.dto.response; | ||
|
||
import com.wedit.weditapp.domain.image.domain.Image; | ||
|
||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
@Getter | ||
@NoArgsConstructor | ||
public class ImageResponseDto { | ||
private String url; | ||
|
||
private int location; | ||
|
||
@Builder | ||
private ImageResponseDto(String url, int location) { | ||
this.url = url; | ||
this.location = location; | ||
} | ||
|
||
public static ImageResponseDto from(Image image){ | ||
return ImageResponseDto.builder() | ||
.url(image.getUrl()) | ||
.location(image.getLocation()) | ||
.build(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
src/main/java/com/wedit/weditapp/domain/invitation/domain/Invitation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 비회원의 조회도 및 URL 생성 api까지 잘 부탁드리겠습니다! 그리고 본인 청첩장 조회의 역할이라면 Member 객체까지 활용하여 멤버와 청첩장 id 가 일치하는 것을 레포지토리에서 조회하는 것이 데이터의 무결성을 보장하기에 좋다고 생각하는데 이 부분에 대해 어떻게 생각하시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 생각인 것 같습니다! 추후 member 객체 활용하는 부분 추가하며 한꺼번에 추가하도록 하겠습니다!