Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend day calculations for week meetings does not exclude days after end date #651

Open
ragesoss opened this issue Feb 5, 2016 · 7 comments

Comments

@ragesoss
Copy link
Member

ragesoss commented Feb 5, 2016

On the Timeline of a Course, the meeting dates are shown for each Week. The start date of each week is determined by the number of weeks, combined with the meeting days each week and the day exceptions that mark days when the course meets or doesn't meet that are exceptions to the normal meeting days. Each week shows the dates that week on which the course meets. However, for the final week it can show a meeting date that happens after the Course's timeline_end or end date.

@Alone-Y154
Copy link

@ragesoss , I would like to work on this issue

@Nikuunj
Copy link

Nikuunj commented Nov 29, 2023

Hi @ragesoss,

I hope this message finds you well. I'm interested in joining the WikiEducationFoundation Slack channel to stay informed and contribute to the discussions. Could you please add me to the channel?

Looking forward to being a part of the community.

@DanAletor
Copy link

Hi @ragesoss, I would like to work on this issue

@shishiro26
Copy link
Contributor

Hii @ragesoss, what's the status of this ? I would like to raise a contribution

@ragesoss
Copy link
Member Author

@shishiro26 it's still open. You're welcome to work on it.

@shishiro26
Copy link
Contributor

@ragesoss, could you provide some examples for this? I'm unable to reproduce the issue. I tried cloning a course, but that doesn't seem to be the correct example I should be working with. I've created several courses, but I'm still unable to reproduce the issue. The photos I included in my PR are related to the course I cloned, but it seems that's not the right example to use, especially since the Travis CI build is also failing.

@ragesoss
Copy link
Member Author

Here's what it looks like:

last week

The timeline includes weeks that extend to the end date. The last week, as shown in the week header, doesn't go a full week, but only 03/30 - 04/01 (the end date). However, the meeting days are set to every day of the week, and these include days after the end date (Wednesday, Thursday, Friday and Saturday) instead of the expected behavior of showing only the meeting days up to the end date.

You should be able to recreate this locally by setting up a course with a timeline, then adding content to the timeline until it extends to the final week (with appropriate settings for meeting days and an end date that occurs in the middle of that week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants