Moving CommandExecutor to WinRM core

[mwrock]

I'm getting started with test-kitchen/winrm-transport#16 pulling in aspects of the winrm-transport's implementation into this gem. winrm-transport was created about the same time this gem was to support windows support in Test-Kitchen. Test-Kitchen uses winrm-transport for both file transfers and it also uses that gems CommandExecutor for ad hoc commands.

Both the CommandExecutor in this gem and winrm-transport have the exact same public interface except its run_powershell is run_powershell_script which can be easily remedied with an alias. Its implementation has a couple added features which will be nice here:

• Managing the lower command quotas of legacy windows versions
• Finalizer to close open connections (needed in ad hoc scenarios)

Even without these added features, the CommandExecutor provides value to many scenarios by virtue of the fact that it makes it easy to call several commands on a single winrm connection instead of opening a new connection for each command.

I'd like to move the CommandExecutor to the core gem so that consuming apps like Test-Kitchen can use it for ad hoc commands. They could do that through this gem but its odd to do so via a gem focused on file transfer capabilities. I think we can do this in a way that is non breaking and I don't think it risks duplicate code.

I'm volunteering to do the code flinging but am opening this issue as a place for discussion.

[sneal]

Make it so 👍

[sneal]

Also see @maxlinc interface proposal for WinRM 2.0 WinRb/WinRM#115

[hh]

Would love to help if any is needed. @mwrock

[mwrock]

closed via #28