Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Crop element select #324

Open
Mystqr4 opened this issue Sep 23, 2023 · 5 comments
Open

[Feature Request] Crop element select #324

Mystqr4 opened this issue Sep 23, 2023 · 5 comments
Labels
enhancement New feature or request Feature-PiP-Crop

Comments

@Mystqr4
Copy link

Mystqr4 commented Sep 23, 2023

I know its a long shot and probably something more down the line if at all but wonder if it is at all possible to add an element select when attempting to crop. It would come in so handy when trying to accurately crop a particularly frame out for example a video window where it could automatically find the video frame on hover and be able to discern the difference between the video frame and the black bars too but also be able to auto detect the video frame with the bars too for those times and people that need it for subtitles.

I guess in similar fashion to the way firefox's default screenshot tool works where it can highlight a certain frame as it finds it. I realise the construct of a website with CSS and frames make it far easier for that to be a thing though but I have no idea what is possible and what isn't but figured it would very useful and make everything much more efficient and accurate at times.

I'm not sure of it could be useful for some but I feel it would just add as an enhancement to what is currently available and make everything a little more fluid without taking away the custom hand selected crop feature either. It seems like it would be a pretty complex thing to add though so I am not sure. I thought it was maybe worth mentioning as something to look at perhaps in the future.

@gileli121
Copy link
Member

gileli121 commented Sep 23, 2023

Good idea, and yes it is possible.
The part of detecting the objects is not as complex as you think.
I know how to do it. In fact, this is what I already did for implementing some existing
functionality.

I have seen your request done using AI, but this is because some developers are not too familiar with Windows API.

The complex part here is about implementing the UI for it.

@gileli121 gileli121 added enhancement New feature or request Feature-PiP-Crop labels Sep 23, 2023
@Mystqr4
Copy link
Author

Mystqr4 commented Sep 23, 2023

Good idea, and yes it is possible. The part of detecting the objects is not as complex as you think. I know how to do it. In fact, this is what I already did for implementing some existing functionality.

I have seen your request done using AI, but this is because some developers are not too familiar with Windows API.

The complex part here is about implementing the UI for it.

Extraordinary! This would be an excellent achievement if it works out the way I suspect it would. It seems like you are already knew exactly what I was thinking without the entire explanation on my part.

The fact that you can do it it without AI makes it even better to me too.

I'm not sure how difficult it will be to add the UI for it but I am sure you will do a great job.

@gileli121
Copy link
Member

gileli121 commented Sep 23, 2023

@Mystqr4

It seems like you already knew exactly what I was thinking without the entire explanation on my part.

I still have not thought about it in detail yet. But currently, I see two approaches - the first one is the "snapping" approach, and the other one is the select-element approach.

Snapping approach

In this approach, I suggest that while you drag the crop selector, it will snap to the edge of the elements. It may be easier to develop.

Select-element approach

In this approach, you basically select an element similar to how you select a dom element in Google Chrome developer tools, and you crop to it..

The fact that you can do it it without AI makes it even better to me too. I'm not sure how difficult it will be to add the UI for it but I am sure you will do a great job.

Thanks. I hope to work on it. it depends on the sales

@Mystqr4
Copy link
Author

Mystqr4 commented Sep 24, 2023

Both are good options.

Snapping approach:
The crop selector whilst easier to implement might annoy people if it constantly snaps to the edge of the wrong element and may lead to frustrations.

Select-Element approach:
This one will probably be best if you can modify the the element select by dragging key points like you can with the firefox screenshot tool. Most times people won't have to but I imagine being able to would help signficantly.

Whatever way you go I feel like it would be a huge improvement and not just for people with made eye sight or less steady hands.

I honestly hope that sales do go up regardless of this potentially new enhancement . The amount of development effort you put into the current release was phenomenal.
Buying this software has been well worth the cost. It took me a while to come around to buying it but I am so glad I did. Last I remember it was well priced and is a lifetime license which entitles you to use it on 3 computers. Can't argue with that really.

@gileli121
Copy link
Member

Probably should switch to this
https://sales.jetbrains.com/hc/en-gb/articles/207240845-What-is-a-perpetual-fallback-license-

(without the subscription part)
Anyway, any user who purchased when it was "lifetime" will keep enjoying it.

Select-Element approach:
This one will probably be best if you can modify the the element select by dragging key points like you can with the firefox screenshot tool. Most times people won't have to, but I imagine being able to would help signficantly.

OK, makes sense. I hope to work on it in the next few months

@gileli121 gileli121 mentioned this issue Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature-PiP-Crop
Projects
None yet
Development

No branches or pull requests

2 participants