Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICARUS configuration regression : threshold tags show up in sigproc config #356

Open
brettviren opened this issue Jan 6, 2025 · 0 comments

Comments

@brettviren
Copy link
Member

This test shows ICARUS config has a regression

bats test/test/test-issue220.bats

 ✗ no wiener_threshold_tag in cfg
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 16)
     `[[ -z "$found" ]]' failed
   found with wiener_threshold_tag:
   /nfs/data/1/bviren/porting/toolkit/cfg/pgrapher/experiment/icarus/sp.jsonnet:      wiener_threshold_tag: 'threshold%d' % anode.data.ident,
 ✗ no threshold tags in cfg - this fails until wclsFrameSaver issue resolved
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 26)
     `[[ -z "$found1" ]]' failed
   found with 'threshold' tags:
   /nfs/data/1/bviren/porting/toolkit/cfg/pgrapher/experiment/icarus/wcls-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /nfs/data/1/bviren/porting/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /nfs/data/1/bviren/porting/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel-omit-noise.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),

2 tests, 2 failures

Note #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant