Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEE setup.py is packaging the plugins #48

Open
Wenzel opened this issue Jun 21, 2018 · 4 comments
Open

SEE setup.py is packaging the plugins #48

Wenzel opened this issue Jun 21, 2018 · 4 comments

Comments

@Wenzel
Copy link

Wenzel commented Jun 21, 2018

Hi,

I noticed that when i install python-see from pip, the plugins are also installed:

In [1]: import plugins

In [2]: plugins.__file__
Out[2]: '/usr/local/lib/python3.6/dist-packages/python_see-1.2.6-py3.6.egg/plugins/__init__.py'

In [3]: 

Having a vague named such as plugins installed as a system wide module is a bit dangerous don't you think ?

Thanks.

@Jorge-Rodriguez
Copy link
Contributor

Jorge-Rodriguez commented Jun 23, 2018

@noxdafox How about moving the plugins from the root to see/lib/plugins instead?
We could move the image providers there too. The context as well, maybe?

@Wenzel
Copy link
Author

Wenzel commented Jun 23, 2018

2 solutions:

  • move them into a seperate package python-see-plugins
  • integrate them into the see package see.plugins

@Jorge-Rodriguez
Copy link
Contributor

I would go for option nr. 2

@noxdafox
Copy link
Contributor

The plugins folder was initially intended as a place where to provide some reference implementation of SEE plugins. It ended up in the package by mistake.

Nevertheless, I think it might be a good idea to add it to the Python package. I will provide soon a patch for moving it to see.plugins. I think is the most sensible solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants