Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify box templates #6167

Open
BurntimeX opened this issue Jan 17, 2025 · 0 comments
Open

Unify box templates #6167

BurntimeX opened this issue Jan 17, 2025 · 0 comments

Comments

@BurntimeX
Copy link
Member

BurntimeX commented Jan 17, 2025 •
edited
Loading

Some boxes use a single template for all possible positions and therefore contain large if/else code blocks. This should be unified to the use of a separate template for the sidebar position.

Examples:
Bad: https://github.com/WoltLab/WCF/blob/6.2/com.woltlab.wcf/templates/boxUserTrophyList.tpl
Good: https://github.com/WoltLab/WCF/blob/6.2/com.woltlab.wcf/templates/boxUserListSidebar.tpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
WoltLab Suite 6.2
Status: Minor Task
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BurntimeX