Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding changes break the maximum slider value #32

Closed
rick-nu opened this issue Nov 30, 2021 · 2 comments
Closed

Padding changes break the maximum slider value #32

rick-nu opened this issue Nov 30, 2021 · 2 comments

Comments

@rick-nu
Copy link

rick-nu commented Nov 30, 2021

My Environment

Dependency Version
Node.JS version v16
react-color-palette version v6.2.0
Codesandbox.io https://codesandbox.io/embed/spring-waterfall-v2673

Expected Behavior:

The maximum value should not depend on padding/margin that is potentially changed.

Actual Behavior:

The slider exceeds the maximum value when the vertical padding is removed. This will change "break" the maximum value:

.rcp-body {
  padding-left: 0;
  padding-right: 0;
}

This is my implementation of the component were the padding is adjusted:

Additional Context:

This ticket is a follow up from #23 (comment). Turns out there is a different reason why the maximum value was not working yet for me.

Workaround:

Don't adjust the padding that are given for now.

@Wondermarin
Copy link
Owner

Duplicate #22

@Wondermarin Wondermarin closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
@rick-nu
Copy link
Author

rick-nu commented Aug 10, 2023

@Wondermarin thank you for the latest version, the ability to separate the components is great. My compliments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants