Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide color fields #4

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Hide color fields #4

merged 8 commits into from
Feb 22, 2021

Conversation

qWici
Copy link
Contributor

@qWici qWici commented Feb 18, 2021

I think it would be nice to be able to hide fields that are not necessary for the user. For example, in my project I want to let the user select the color only with HEX code.
I haven't found contributing guide so I'm not sure how to test and build this project correctly. If you need any other changes on this code - I will be happy to do it. And thanks for the great package

@Wondermarin
Copy link
Owner

Yes, I thought to implement it, but you beat me to it :)

Thank you for reminding me about the contributing guide, I will definitely add it, as well as the tests.

I'll check it out and merge it tomorrow.

@Wondermarin Wondermarin reopened this Feb 18, 2021
Copy link
Owner

@Wondermarin Wondermarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and fixed some things, as soon as you change the file name I'll be ready to merge the branches.

Thank you for your help <3

src/utils/index.ts Outdated Show resolved Hide resolved
src/utils/isValidHex/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@Wondermarin Wondermarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work, the minor update will be released today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants