Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some combinations of IFE blanket parameters cause an exception running costing code #65

Closed
craastad opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@craastad
Copy link
Contributor

craastad commented Aug 19, 2024

This was observed when working on the IFE portion of the web costing calculator.

The goal of this task is to investigate the parameters and calculations that cause the error and propose changes to allow all feasible sets of IFE blanket parameters. This would be a good task to add some automated tests for verification, running costing code for inputs and asserting cost calculations work.

Relevant code:

The committed definition work without error:

blanket=Blanket(
            first_wall=BlanketFirstWall.LIQUID_LITHIUM,
            blanket_type=BlanketType.FLOWING_LIQUID_FIRST_WALL,
            primary_coolant=BlanketPrimaryCoolant.LITHIUM_LI,
            secondary_coolant=BlanketSecondaryCoolant.WATER,
            neutron_multiplier=BlanketNeutronMultiplier.PB_AS_PART_OF_PBLI,
            structure=BlanketStructure.FERRITIC_MARTENSITIC_STEEL_FMS,
        ),

Parameters that cause the issue:

blanket=Blanket(
          first_wall=BlanketFirstWall.FLIBE,
          blanket_type=BlanketType.SOLID_FIRST_WALL_WITH_A_LIQUID_BREEDER,
          primary_coolant=BlanketPrimaryCoolant.LITHIUM_LI,
          secondary_coolant=BlanketSecondaryCoolant.WATER,
          neutron_multiplier=BlanketNeutronMultiplier.PB_AS_PART_OF_PBLI,
          structure=BlanketStructure.FERRITIC_MARTENSITIC_STEEL_FMS,
      ),

TODO add output of exception

@craastad craastad added bug Something isn't working good first issue Good for newcomers labels Aug 19, 2024
@craastad
Copy link
Contributor Author

Fixed in #68
Related to Issue #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants