Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncovering the Cover Block #913

Closed
Tracked by #2002 ...
westnz opened this issue Aug 29, 2022 · 20 comments
Closed
Tracked by #2002 ...

Uncovering the Cover Block #913

westnz opened this issue Aug 29, 2022 · 20 comments
Assignees
Labels
[Content] Published Marks closed issues as content that was actually published.

Comments

@westnz
Copy link
Collaborator

westnz commented Aug 29, 2022

//lesson

@westnz westnz self-assigned this Aug 29, 2022
@westnz westnz added [Component] Content Website development issues related to the content on Learn. [Content Type] Tutorial labels Aug 29, 2022
@westnz westnz changed the title Uncover the Cover Block Uncovering the Cover Block Aug 30, 2022
@westnz

This comment was marked as outdated.

@azhiya
Copy link
Collaborator

azhiya commented Sep 6, 2022

@artdecotech has volunteered to review this.

@azhiya azhiya assigned westnz and unassigned westnz Sep 6, 2022
@artdecotech

This comment was marked as outdated.

@westnz

This comment was marked as outdated.

@amitpatel0702

This comment was marked as outdated.

@westnz
Copy link
Collaborator Author

westnz commented Sep 8, 2022

Thank you very much @amitpatel0702

@westnz
Copy link
Collaborator Author

westnz commented Sep 19, 2022

Review: CTA example
M: "should not use headers for text size or styling, headers are for identifying sections"

@azhiya azhiya moved this to 🔎 Review in Progress in LearnWP Content - Development Oct 2, 2022
@westnz
Copy link
Collaborator Author

westnz commented Oct 14, 2022

Published: https://learn.wordpress.org/tutorial/uncovering-the-cover-block/

@westnz westnz moved this from 🔎 Review in Progress to 📜 Published or Closed in LearnWP Content - Development Oct 14, 2022
@westnz westnz closed this as completed Nov 1, 2022
@courtneyr-dev courtneyr-dev moved this from 📜 Published or Closed to 🚧 Drafts in Progress in LearnWP Content - Development Jul 5, 2023
@courtneyr-dev
Copy link
Collaborator

courtneyr-dev commented Jul 19, 2023

WordPress/gutenberg#41153 6.3
image of text color controls, image of layout controls.
WordPress/gutenberg#45326
Add text color controls and borders support (41153).
Add text color controls (41572).
Simplify cover block description. (50355).
Add constrained/flow layout to Cover block (45326).

@kaitohm kaitohm removed 6.3 [Component] Content Website development issues related to the content on Learn. labels Dec 5, 2023
@westnz
Copy link
Collaborator Author

westnz commented Jan 23, 2024

I plan to update and use this tutorial in the learning pathway project.

@westnz westnz assigned ghost Mar 25, 2024
@ghost
Copy link

ghost commented May 20, 2024

@westnz I am giving myself a due date of June 7th for this lesson.

@ghost ghost removed their assignment Jun 10, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Lesson Development Checklist

  • Gather any relevant links to Support, Docs, or related material
  • Description and Objectives finalized
  • Lesson created and announced to the team for review
  • Lesson reviewed
  • Lesson video submitted and published to WPTV
  • Lesson created on Learn.WordPress.org
  • Lesson video published to YouTube
  • Lesson on Learn.WordPress.org updated with YouTube video
  • Lesson published to Learn.WordPress.org

@westnz

This comment was marked as outdated.

@westnz westnz moved this from 🚧 Drafts in Progress to 🔎 Ready for Review in LearnWP Content - Development Jun 13, 2024
@moltilearn
Copy link

Another review for contributor day today, and here is my comment.
Thanks for your great video, i followed your instructions step-by-step and could create the examples with ease. I struggled with the parallax example at 4.40 with the block spacing setting, I didn't see the option. We at contributor day found out that it depents on the theme, in my case I use Neve, after changing the theme to Twenty Twenty-Two, the block spacing option is there. Do we need to mention that it can be different depending on theme set?
Cheers from Torino.

@ironnysh
Copy link

Tutorial/Lessons Review Checklist

  • Learning outcomes/objectives are clear.
  • Technical concepts introduced in the content are accurate.
  • The speed of demonstrations are easy to follow.
  • The narration audio matches what is shown visually.
  • Spelling and grammar are correct.
  • Sound quality is consistent throughout the video.
  • Brand Usage Guidelines and Promotional Guidelines are being followed.
  • Media assets are all in the public domain (CC0).

Great tutorial, @westnz. The hands-on demos are very cool.

There's one a11y issue with the hero video example: it defaults to autoplay and loop, which is a WCAG violation (and somewhat annoying 😅).

The problem is caused by how the block was coded in Gutenberg (see this open issue), but I think it's worth pointing out in the lesson.

@westnz
Copy link
Collaborator Author

westnz commented Jun 13, 2024

Thank you for the feedback folks

@ironnysh, I think I am going to use another example instead of the video banner then.

@westnz
Copy link
Collaborator Author

westnz commented Jun 14, 2024

LP.Uncovering.the.Cover.block.mp4

@westnz
Copy link
Collaborator Author

westnz commented Jun 14, 2024

Added a new version and re-recorded the first example.

@westnz westnz moved this from 🔎 Ready for Review to ✅ Preparing to Publish in LearnWP Content - Development Jun 18, 2024
@westnz
Copy link
Collaborator Author

westnz commented Jun 18, 2024

//published

@github-actions github-actions bot added the [Content] Published Marks closed issues as content that was actually published. label Jun 18, 2024
@github-project-automation github-project-automation bot moved this from ✅ Preparing to Publish to 📜 Published or Closed in LearnWP Content - Development Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Content] Published Marks closed issues as content that was actually published.
Projects
Status: 📜 Published or Closed
Development

No branches or pull requests

8 participants