Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks Navigation menu: use links not buttons #11711

Closed
Tracked by #29733
afercia opened this issue Nov 10, 2018 · 4 comments · Fixed by #35655
Closed
Tracked by #29733

Blocks Navigation menu: use links not buttons #11711

afercia opened this issue Nov 10, 2018 · 4 comments · Fixed by #35655
Assignees
@ramonjd
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress

Comments

@afercia
Copy link
Contributor

afercia commented Nov 10, 2018

For the same reason the "Content structure" menu (also known as "Document outline") is going to use in-page links, see #7142 and #10815, also the Blocks Navigation menu should use links.

Right now, the Blocks navigation buttons are used fot content navigation. They're emulating the hyperlinks behaviour "by moving keyboard (and viewport) focus to the relevant area, but the behaviour may be unpredictable to blind users".
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 10, 2018
This was referenced Nov 10, 2018
Closed
Closed
Closed
Merged
@designsimply designsimply added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label Nov 11, 2018
@afercia afercia mentioned this issue Feb 26, 2019
Closed
@afercia afercia mentioned this issue Mar 8, 2019
Merged
4 tasks
@paaljoachim
Copy link
Contributor

I see multiple PRs that have been closed and two merged.
I will close this issue. If I am mistaken then please reopen.

@joedolson Joe I am pinging you to Andrea's issue as you will have seen. Just to be sure that I am doing this correctly.

@joedolson
Copy link
Contributor

It looks like the outline navigation is now using links, but it took me a while to figure that out, since they're only active when focused. The flow using the mouse is not functional. I would expect these to be available both using the mouse and the keyboard.

@paaljoachim
Copy link
Contributor

Should we reopen this issue?

@joedolson
Copy link
Contributor

Yes, this should probably be re-opened. The problem was solved, but the implementation is buggy.

@joedolson joedolson reopened this Jan 13, 2021
@priethor priethor mentioned this issue Mar 10, 2021
Closed
13 tasks
@ramonjd ramonjd mentioned this issue Oct 15, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramonjd ramonjd

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Editor List View: use anchor elements instead of buttons WordPress/gutenberg
5 participants
@designsimply @afercia @joedolson @paaljoachim @ramonjd