Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic editor 'more options' disappears at 220% zoom #12104

Closed
johngodley opened this issue Nov 20, 2018 · 5 comments · Fixed by #17323
Closed

Classic editor 'more options' disappears at 220% zoom #12104

johngodley opened this issue Nov 20, 2018 · 5 comments · Fixed by #17323
Assignees
Labels
[Block] Classic Affects the Classic Editor Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress

Comments

@johngodley
Copy link
Contributor

Not sure how much of a problem this is, but if you zoom in the classic editor the 'more options' button disappears at a certain point. Here is 200%:

edit_post_ _wordpress_latest_ _wordpress

And it disappears at 220%:

edit_post_ _wordpress_latest_ _wordpress

The other buttons all wrap round properly as you zoom further

The more button also seems to be 1 pixel too far down vertically, and overlaps the border when you highlight it.

To Reproduce
Steps to reproduce the behavior:

  1. Add a classic editor block
  2. Zoom the browser window to 220%
  3. Note the more options ellipsis menu disappears

Desktop (please complete the following information):
Mac+Chrome

@johngodley johngodley added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 20, 2018
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Block] Classic Affects the Classic Editor Block labels Nov 20, 2018
@designsimply
Copy link
Member

I tested using WordPress 4.9.8 and Gutenberg 4.4 with Firefox 63.0.1 on macOS 10.13.6 and found that the more menu moves from the top right of the block to below the block at 240% zoom.

screen shot 2018-11-20 at 10 51 09 am
Seen at https://tan-otter.jurassic.ninja/wp-admin/post.php?post=19&action=edit running WordPress 4.9.8 and Gutenberg 4.4 using Firefox 63.0.1 on macOS 10.13.6.

I found the same for Chrome 70.0.3538.77 on macOS 10.13.6:

screen shot 2018-11-20 at 10 54 07 am
Seen at https://tan-otter.jurassic.ninja/wp-admin/post.php?post=19&action=edit running WordPress 4.9.8 and Gutenberg 4.4 using Chrome 70.0.3538.77 on macOS 10.13.6.

This is the same behavior that we see on mobile (see background explanation at #7256 (comment)).

Perhaps it is still an accessibility issue due to how the placement of the button moves to below the block though?

@designsimply designsimply added Needs Accessibility Feedback Need input from accessibility and removed [Type] Bug An existing feature does not function as intended labels Nov 20, 2018
@johngodley
Copy link
Contributor Author

Ah yes, I was looking at a long block and didn't notice the menu was at the bottom!

@afercia
Copy link
Contributor

afercia commented Nov 23, 2018

Discussed during today's accessibility bug scrub. Usually, users who need a very high "zoom in" level use screen magnifier software. These tools shouldn't trigger the behavior that moves the More Options button to the bottom.

However, the real a11y issue here is that visual order doesn’t match the DOM order. Worth considering a good percentage of users with accessibility need use their mobile device connected to a keyboard: https://webaim.org/projects/screenreadersurvey7/#mobilekeyboard

Also, this issue seems already covered by #9739 ?

@sabernhardt
Copy link
Contributor

Would it be a good idea to include "maximum-scale=2.0" in the viewport meta tag as a temporary fix, hoping that anyone who needs it larger than 200% uses a screen magnifier as well?

@anevins12
Copy link
Contributor

We need content and functionality to work up to 400% and I don't recommend putting maximum scales on things - sounds like @afercia has found the underlying issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants