Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Overlap When Embed Block is Initial Block #1279

Closed
mrjarbenne opened this issue Jun 19, 2017 · 1 comment · Fixed by #1296
Closed

Menu Overlap When Embed Block is Initial Block #1279

mrjarbenne opened this issue Jun 19, 2017 · 1 comment · Fixed by #1296

Comments

@mrjarbenne
Copy link

If you don't add any text, and instead insert an embed block as the first object, subsequently clicking on the + button renders the menu under the top bar, obscuring the first few options:

2017-06-19_16-28-41

This is with the plugin version in the repo version 0.1.0

@aduth
Copy link
Member

aduth commented Jun 19, 2017

Related: #1193

This is an issue with the existing implementation detecting boundary collisions to flip the inserter. Currently it detects if it exceeds the top of the entire page (above admin bar), when it should be detecting against the bottom of the editor bar.

https://github.com/WordPress/gutenberg/blob/cab8713/components/popover/index.js#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants