Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block toolbar DOM order and visual order mismatch in the responsive view #14419

Closed
afercia opened this issue Mar 13, 2019 · 0 comments · Fixed by #18686
Closed

Block toolbar DOM order and visual order mismatch in the responsive view #14419

afercia opened this issue Mar 13, 2019 · 0 comments · Fixed by #18686
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 13, 2019

Splitting this out from #9739

In the responsive view, the block toolbar changes position and it's placed after the block together with the block "movers" and the Add block button:

Screenshot 2019-03-13 at 18 39 17

However, to my understanding there's some DOM repositioning but it's mainly a visual repositioning. The DOM order is mostly the same as in the desktop view. This way, visual order and DOM order mismatch and don't make any sense.

Worth reminding many screen reader users use a keyboard when using their mobile devices so keyboard operability is relevant also in the mobile view.

It's also a WCAG failure but, regardless, it makes operating with a keyboard nearly impossible and should be fixed. If a reordering is desired, it should change also the DOM order to match the visual order.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant