Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings button: Firefox and NVDA don't announce the aria-expanded state #14474

Closed
afercia opened this issue Mar 16, 2019 · 0 comments · Fixed by #14475
Closed

Settings button: Firefox and NVDA don't announce the aria-expanded state #14474

afercia opened this issue Mar 16, 2019 · 0 comments · Fixed by #14475
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 16, 2019

See #1387, #1388, #1537, #1560.

Although the original NVDA bug was fixed in the 2018.4 alpha builds, the fix was then reverted. Thus, there are still cases where Firefox and NVDA aren't able to announce a change in the aria-expanded state.

As explained in the NVDA issue, this is caused by a mix of reasons:

  • when there's a CSS pseudo-element change, Firefox rebuilds the set of accessible properties (Firefox bug)
  • NVDA thinks it's a new element and doesn't speak anything, not even a focus change (NVDA original bug)

In the case of the Settings button, when the button is not toggled, there's no CSS pseudo-element. Only when the button is toggled, a CSS pseudo-element gets generated.

Testing with Firefox 65 and NVDA 2018.4.1 nothing is announced. See in the animated GIF below:

  • when landing on the button, NVDA correctly announces "Settings button expanded"
  • toggling the button, nothing gets announced

settings button aria expanded NVDA

Seems to me this button styling can be implemented even without the CSS pseudo-element, which would solve the issue. Will try a quick PR.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Mar 16, 2019
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Mar 22, 2019
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants