Settings button: Firefox and NVDA don't announce the aria-expanded state #14474
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Good First Issue
An issue that's suitable for someone looking to contribute for the first time
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Milestone
See #1387, #1388, #1537, #1560.
Although the original NVDA bug was fixed in the 2018.4 alpha builds, the fix was then reverted. Thus, there are still cases where Firefox and NVDA aren't able to announce a change in the
aria-expanded
state.As explained in the NVDA issue, this is caused by a mix of reasons:
In the case of the Settings button, when the button is not toggled, there's no CSS pseudo-element. Only when the button is toggled, a CSS pseudo-element gets generated.
Testing with Firefox 65 and NVDA 2018.4.1 nothing is announced. See in the animated GIF below:
Seems to me this button styling can be implemented even without the CSS pseudo-element, which would solve the issue. Will try a quick PR.
The text was updated successfully, but these errors were encountered: