Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the link dialog box #17378

Closed
paaljoachim opened this issue Sep 9, 2019 · 3 comments
Closed

Improving the link dialog box #17378

paaljoachim opened this issue Sep 9, 2019 · 3 comments
Labels
[Block] Paragraph Affects the Paragraph Block [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Sep 9, 2019

Is your feature request related to a problem? Please describe.
It can be difficult in renaming an existing link.

Describe the solution you'd like
I would like a straight forward way of renaming a link.

Here is a suggestion. Click the arrow to open to see the link name.

Link-dialog-box-ver1

@swissspidy swissspidy added [Block] Paragraph Affects the Paragraph Block [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement. labels Oct 1, 2019
@swissspidy
Copy link
Member

It can be difficult in renaming an existing link.

Why is that so?

I would like a straight forward way of renaming a link.

It should be possible to change the text just by... editing it inline.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Oct 2, 2019

I am backing up some...
Let's look at the "old" method.

Screen Shot 2019-10-02 at 07 33 09

Then compare with the new Gutenberg way.

Screen Shot 2019-10-02 at 07 40 17

Comparing the two the most important part that is missing is the line to define the text link.
Here is the mockup suggestion again.

Gutenberg-link

Difficult in renaming a link. Pascal you asked "Why is that so" and editing inline.
It would be cleaner to have a text link box. Keeping it straight forward. Clarity to adjusting the link. Yes one can adjust it inline but that is just not as clean as having a line like the "old way" of doing so. If one wanted to add multiple words to a link after having first created the link then that becomes difficult. It would then be very easy to open up the link "submenu" see the link name and then adjust.

@karmatosed
Copy link
Member

@paaljoachim for now going to close this in favour of the iteration going on here #17557. This entire interface if being worked on so good to focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants