NavigationMenuItem: Close dropdown once option selected.

[retrofox]

There's no way to close the dropdown once options are selected except for clicking outside or pressing Esc. Perhaps a close button would be useful?

[tellthemachines]

@retrofox I'm not sure if this issue refers to the link selection dropdown (because we previously discussed the same issue happening with the colour palette dropdown) but it's certainly happening there, so I'm attaching a screenshot of it for clarity:

Feel free to edit this or add more info if you were referring to another dropdown!

Edit: This component also doesn't close on click outside on any Windows browser (tested on Windows 10 with IE11, Chrome and Firefox).

[karmatosed]

I explored this a bit, my concern though is we are getting to that situation of 2 things close together even we stagger this:

[shaunandrews]

We could try moving the "Change" button down to its own line. Also shown on the right is an idea of making the popover narrower when the Link Title and URL are shorter — but grow as needed.

[karmatosed]

@shaunandrews that seems like a reasonable middle ground, going to remove design feedback label and let's go with that for now.

[getdave]

I agree we need this, but (personal opinion alert!) the visuals look a lot less elegant to me now that the Change button isn't on the right hand side.

Without the X icon breaking outside the boundaries of the popover (which I assume would be outside design style guide) I don't see any other option however.

Also noting that Google docs doesn't have a close button so just confidence checking that we definitely need to do this...

[WunderBart]

I second @getdave's opinion - not sure if we definitely need this.

Regarding closing via ESC - it actually doesn't work in the following scenario:

1. Click ⊕ to add new nav item,
2. Define a URL and press enter,
3. The popup should remain open showing the created link details but will go out of focus (?) and won't be closable by ESC,
4. Press TAB to bring one of popup's elements to focus and then ESC to close the popup.

Does that sound like something that could be addressed within this issue? Happy to create another issue otherwise.

[shaunandrews]

Seems like #19481 could be related.

[tellthemachines]

Is this still needed now that the dropdown closes itself on link selection?

[draganescu]

Hi @tellthemachines from my testing this does not feel like a need anymore. I will close this but pinging @shaunandrews for second opinion.