-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Block: Add background/text color support #18989
Comments
I am doing a status update. It is still missing color controls. Associated issue: |
Actually the File block is missing Color and Typography controls. |
Hi @paaljoachim - I don't see any problem implementing the typography control. What I found is that the text of the filename is a link, how should we handle that regarding to colors? Also, there's a button as well, should that have separate controls for colors/typography? |
@juanfra if you'd be interested in working on this, it's probably easier to see what works better in a PR. We can also loop in Mel for design feedback. |
Also happy to provide feedback here. Specifically on the question of colors, I would think global styles would eventually allow us to opt in to supporting link colors, so you'd have 3 color options — background, text, and links. |
Hey @juanfra Juan Here is an example from the Heading block. Also the Paragraph block has Text, Background and Link colors. Thank you Juan! |
The File Block has an optional button, but you can't change the background or text colors of that button. This can present a problem if your site's background color conflicts with the default button color. For example:
We should consider adding color support to this block.
The text was updated successfully, but these errors were encountered: