Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Block: Add background/text color support #18989

Closed
melchoyce opened this issue Dec 7, 2019 · 7 comments
Closed

File Block: Add background/text color support #18989

melchoyce opened this issue Dec 7, 2019 · 7 comments
Labels
[Block] File Affects the File Block [Type] Enhancement A suggestion for improvement.

Comments

@melchoyce
Copy link
Contributor

The File Block has an optional button, but you can't change the background or text colors of that button. This can present a problem if your site's background color conflicts with the default button color. For example:

image

We should consider adding color support to this block.

@melchoyce melchoyce added the [Block] File Affects the File Block label Dec 7, 2019
@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 18, 2021

I am doing a status update.
The File block looks currently like this:

Screen Shot 2021-01-18 at 21 37 17

It is still missing color controls.

Associated issue:
Consider adding color and text size customizations to all text-based blocks.
#8171

@paaljoachim paaljoachim added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Jan 18, 2021
@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 30, 2021

Actually the File block is missing Color and Typography controls.
Both controls are needed. All blocks that handle text in some way are to have both of these controls in place.

@juanfra
Copy link
Member

juanfra commented Apr 6, 2021

Hi @paaljoachim - I don't see any problem implementing the typography control. What I found is that the text of the filename is a link, how should we handle that regarding to colors? Also, there's a button as well, should that have separate controls for colors/typography?

@gwwar
Copy link
Contributor

gwwar commented Apr 7, 2021

Also, there's a button as well, should that have separate controls for colors/typography?

@juanfra if you'd be interested in working on this, it's probably easier to see what works better in a PR. We can also loop in Mel for design feedback.

@jasmussen
Copy link
Contributor

Also happy to provide feedback here. Specifically on the question of colors, I would think global styles would eventually allow us to opt in to supporting link colors, so you'd have 3 color options — background, text, and links.

@paaljoachim
Copy link
Contributor

Hey @juanfra Juan

Here is an example from the Heading block. Also the Paragraph block has Text, Background and Link colors.

Screen Shot 2021-04-08 at 19 44 17

Thank you Juan!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 4, 2021
@carolinan carolinan removed Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress labels Mar 8, 2024
@carolinan
Copy link
Contributor

For the color of the button in the file block please see
#52850
#57314

@carolinan carolinan removed the Needs Dev Ready for, and needs developer efforts label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants