Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some blocks might not play well inside vertical aligned columns #19962

Closed
mrleemon opened this issue Jan 30, 2020 · 6 comments · Fixed by #20368
Closed

Some blocks might not play well inside vertical aligned columns #19962

mrleemon opened this issue Jan 30, 2020 · 6 comments · Fixed by #20368
Assignees
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mrleemon
Copy link
Contributor

mrleemon commented Jan 30, 2020

Describe the bug
Playing with the Slideshow block in Jetpack, I found a possible bug in the Columns block.

To reproduce
Steps to reproduce the behavior:

  1. Install and activate Jetpack
  2. Add a columns block (using the 50%-50% layout preset) in a page
  3. Add a Slideshow block inside one of the columns and add some images to it
  4. Set a explicit vertical alignment in the columns block (top, center or bottom)
  5. The Slideshow disappears

Expected behavior
The block works as expected

Screenshots
alignment-none
alignment-top
alignment-center
alignment-bottom

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox 72 and Chrome 79

Additional context

  • I'm using the Gutenberg version that comes with WordPress 5.3.2

Possible fix

If I add width: 100% to the .wp-block-column.is-vertically-aligned-top, .wp-block-column.is-vertically-aligned-center and .wp-block-column.is-vertically-aligned-bottom CSS rules in Gutenberg, the slider block works as expected:

.wp-block-column.is-vertically-aligned-center {
    align-self: center;
    width: 100%; /* new */
}
@jorgefilipecosta
Copy link
Member

Hi @mrleemon, thank you for reporting this issue. Hi @getdave, would you be able to have a look into this problem?

@jorgefilipecosta jorgefilipecosta added [Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended labels Feb 3, 2020
@mrleemon
Copy link
Contributor Author

The Image Slider block from the following plugin https://wordpress.org/plugins/getwid/ suffers the same problem.

@mrleemon
Copy link
Contributor Author

mrleemon commented Feb 15, 2020

The Image Slider block from the following plugin https://wordpress.org/plugins/ultimate-blocks/ doesn't overflow the column when vertically aligned but there are some visual glitches if the width: 100% property is not present.

without
with

@mrleemon
Copy link
Contributor Author

mrleemon commented Feb 15, 2020

The Image Slider block from the plugin https://wordpress.org/plugins/otter-blocks/ is affected by this, too.

otter-without
otter-with

@mrleemon
Copy link
Contributor Author

The Gutenbee plugin https://wordpress.org/plugins/gutenbee/ is also affected by this.

gutenbee-without
gutenbee-with

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 18, 2020

Andrew @aduth
I think this is an issue you might want to know about. (Since you have been working a lot with columns lately.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants