Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: base font and scale #21030

Closed
karmatosed opened this issue Mar 19, 2020 · 2 comments
Closed

Global styles: base font and scale #21030

karmatosed opened this issue Mar 19, 2020 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

Being able to easily adjust a scale of typography opens up some powerful combinations of design. There could be 2 potential ways of doing this.

Declare a base font

image

Pull base from text

The other option is to have the text size be the base and just scale up from it, simply showing a scale and in conjunction with #21028 show that size.

image

Wider picture

In the context of global styles this could look like the following picture:

all

Feedback

As it would be great to move this to development, deciding which approach would be a great step here to continue forward.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts Needs Decision Needs a decision to be actionable or relevant Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Mar 19, 2020
@mtias mtias mentioned this issue Mar 19, 2020
82 tasks
@jasmussen
Copy link
Contributor

Really nice mockups.

As I looked at the GIF of the delicious work in progress in #20530 (comment), however, I realized that headings in my themes often diverge wildly from a typescale, whether it be through font sizes, or even font weights and styles, perhaps even fonts. Locking it to body and header feels like it might be a simpler user interface up front compared to showing options for headings 1 through 6 — but the latter ultimately seems like the way that will frustrate less.

@karmatosed
Copy link
Member Author

There has been a lot of work in this area which means this issue is no longer valid. I am therefore going to close it to allow focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants