-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make link in link dialogue navigate the user to the page within the site editor #22432
Comments
Prototype i2I tried another iteration that uses a button instead of the link. This likely could be more predictable. I did take the liberty of changing the "Change" button to a "Remove link" button. I'm not entirely sold on the icon. I tried a few edit icons, but that felt very much like I was editing the link and not going to a page to edit. I'm open to ideas here. Screenshot |
@shaunandrews has proposed a series of iterations to the link UI that render this mockup fairly outdated. In his mocks, he proposed this: I think it works well with the new UI particularly as it's not relying on an icon. What do you think? |
Just having a single chevron down might be a little too "cryptic" — maybe having a label too would help? or some way to separate it from "Done"? — but apart from that I think it's a solid solution. I think the copywriting needs some iterations (I think it's important it highlights better what's going to happen), but again, it's just a minor review step. |
Closing this due to lack of activity and to make it part of #23328 |
This is an idea previously shared in #19204. If you are familiar with Google Docs, this concept should be familiar. In Google Docs, if you click a link, a popover shows up with editing controls and a clickable link. We could do something similar.
Try the prototype.
Notes
This does require many clicks but is likely more discoverable initially than hotkeys. It also doesn't require any new UI patterns.
Screenshot
Source Figma file
The text was updated successfully, but these errors were encountered: