Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Add links to the post title block when used in the query #23861

Closed
carolinan opened this issue Jul 10, 2020 · 1 comment · Fixed by #25341
Closed

FSE: Add links to the post title block when used in the query #23861

carolinan opened this issue Jul 10, 2020 · 1 comment · Fixed by #25341
Assignees
Labels
[Block] Post Title Affects the Post Title Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress

Comments

@carolinan
Copy link
Contributor

With full site editing enabled, the query /loop block renders the blocks that are placed inside it.

Compare
https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/query-loop/index.php#L32

With the latest post block that has links for the titles:
https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/latest-posts/index.php#L95

There needs to be context added so that theme developers can choose when the title
is a link text for a link leading to the content (archives), and when it is not (single view).

Two things that makes this more difficult is:

  • Untitled posts/pages and providing an alternative way to reach the content. Should the "no title" text always be output? Today this is up to the theme author to decide by using filters.
  • Theme authors don't always make this title a link even for archives. Sometimes, they design the theme in a way that there is only a read more link.
@carolinan carolinan added [Block] Post Title Affects the Post Title Block [Feature] Full Site Editing [Type] Discussion For issues that are high-level and not yet ready to implement. labels Jul 10, 2020
@carolinan
Copy link
Contributor Author

What if there was a toggle control for the block (and the site title block as well), where you could turn the link on and off?

@carolinan carolinan removed the [Type] Discussion For issues that are high-level and not yet ready to implement. label Aug 19, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 15, 2020
@kjellr kjellr added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants