Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit-site package: Latest package versions contain outdated file #24941

Closed
ockham opened this issue Aug 31, 2020 · 8 comments
Closed

Edit-site package: Latest package versions contain outdated file #24941

ockham opened this issue Aug 31, 2020 · 8 comments
Labels
npm Packages Related to npm packages [Type] Bug An existing feature does not function as intended

Comments

@ockham
Copy link
Contributor

ockham commented Aug 31, 2020

Describe the bug
I'm trying to use @wordpress/edit-site's current version (1.11.7, published 5 days ago ) in a project (Automattic/wp-calypso#44928). However, I've noticed that the package's src/index.js file doesn't reflect the current state but a state prior to the last PR that touched that file (#23775, merged on July 20 -- more than a month ago).

I'm somewhat concerned that our package release script might be broken, and I wonder if this also affects other packages.

To reproduce
Steps to reproduce the behavior:

  1. Clone the Automattic/wp-calypso repo.
  2. Check out the branch attached to Site Editor on WP.com: Initial explorations, take two Automattic/wp-calypso#44928.
  3. Run yarn (or yarn distclean && yarn, if you already had it checked out).
  4. Inspect node_modules/@wordpress/edit-site/src/index.js. You'll notice that it has this part in initialize (which should no longer be there, as of Remove more initial PHP state #23775):
	const initialState = settings.editSiteInitialState;
	delete settings.editSiteInitialState;
	initialState.settings = settings;

Expected behavior
The src/index.js file in the @wordpress/edit-site package to reflect the current state.

Additional context
The problem was also present in the previous version of the package, 1.11.6, which was also published after #23775 was merged.

cc/ @gziolo @youknowriad @mcsf @noahtallen @vindl @sirreal

@ockham ockham added [Type] Bug An existing feature does not function as intended npm Packages Related to npm packages [Feature] Full Site Editing labels Aug 31, 2020
@ockham ockham self-assigned this Aug 31, 2020
@youknowriad
Copy link
Contributor

There's no problem here, I don't think we many any major npm release since WordPress 5.5 beta 1. We could start doing these again.

@ockham
Copy link
Contributor Author

ockham commented Aug 31, 2020

There's no problem here, I don't think we many any major npm release since WordPress 5.5 beta 1. We could start doing these again.

Not sure I understand -- does that mean that minor package releases contain the exact same snapshots of files as the latest major one? 🤔

@ockham ockham removed their assignment Aug 31, 2020
@youknowriad
Copy link
Contributor

no, it means we made some package releases recently with some specific cherry-picks into the wp/5.5 branch and we didn't include the latest changes from the Gutenberg plugin/master.

We do pause the npm releases (major ones) during the beta/RC cycle of WordPress releases but now we can resume doing so after plugin releases.

@youknowriad
Copy link
Contributor

@ockham
Copy link
Contributor Author

ockham commented Aug 31, 2020

Okay, in that case, it'd be great if we could release packages.

Still trying to wrap my head around what the implications are for minor package releases (i.e. what kind of changes were being published).

@youknowriad
Copy link
Contributor

Still trying to wrap my head around what the implications are for minor package releases (i.e. what kind of changes were being published).

Bug fixes meant to be backported to WordPress 5.5 and 5.5.1. Basically all PRs that had the "Backport to WP" label.

@ockham
Copy link
Contributor Author

ockham commented Aug 31, 2020

Still trying to wrap my head around what the implications are for minor package releases (i.e. what kind of changes were being published).

Bug fixes meant to be backported to WordPress 5.5 and 5.5.1. Basically all PRs that had the "Backport to WP" label.

Gotcha, thanks! 👍

@gziolo
Copy link
Member

gziolo commented Feb 1, 2021

It looks like it isn’t actionable.

@gziolo gziolo closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Packages Related to npm packages [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants