-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit-site package: Latest package versions contain outdated file #24941
Comments
There's no problem here, I don't think we many any major npm release since WordPress 5.5 beta 1. We could start doing these again. |
Not sure I understand -- does that mean that minor package releases contain the exact same snapshots of files as the latest major one? 🤔 |
no, it means we made some package releases recently with some specific cherry-picks into the We do pause the npm releases (major ones) during the beta/RC cycle of WordPress releases but now we can resume doing so after plugin releases. |
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/release.md#synchronizing-wordpress-trunk this is what I call "major npm releases" |
Okay, in that case, it'd be great if we could release packages. Still trying to wrap my head around what the implications are for minor package releases (i.e. what kind of changes were being published). |
Bug fixes meant to be backported to WordPress 5.5 and 5.5.1. Basically all PRs that had the "Backport to WP" label. |
Gotcha, thanks! 👍 |
It looks like it isn’t actionable. |
Describe the bug
I'm trying to use
@wordpress/edit-site
's current version (1.11.7, published 5 days ago ) in a project (Automattic/wp-calypso#44928). However, I've noticed that the package'ssrc/index.js
file doesn't reflect the current state but a state prior to the last PR that touched that file (#23775, merged on July 20 -- more than a month ago).I'm somewhat concerned that our package release script might be broken, and I wonder if this also affects other packages.
To reproduce
Steps to reproduce the behavior:
yarn
(oryarn distclean && yarn
, if you already had it checked out).node_modules/@wordpress/edit-site/src/index.js
. You'll notice that it has this part ininitialize
(which should no longer be there, as of Remove more initial PHP state #23775):Expected behavior
The
src/index.js
file in the@wordpress/edit-site
package to reflect the current state.Additional context
The problem was also present in the previous version of the package, 1.11.6, which was also published after #23775 was merged.
cc/ @gziolo @youknowriad @mcsf @noahtallen @vindl @sirreal
The text was updated successfully, but these errors were encountered: