Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please upgrade babel-eslint to @babel/eslint-parser in @wordpress/eslint-plugin #29179

Closed
mahnunchik opened this issue Feb 20, 2021 · 1 comment
Closed

Please upgrade babel-eslint to @babel/eslint-parser in @wordpress/eslint-plugin #29179

mahnunchik opened this issue Feb 20, 2021 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mahnunchik
Copy link

What problem does this address?

babel-eslint module is deprecated and will no longer receive updates.

gutenberg/packages/eslint-plugin/package.json

Line 35 in e3d64f5

"babel-eslint": "^10.1.0",

What is your proposed solution?

Update to @babel/eslint-parser
@talldan talldan added [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take labels Feb 25, 2021
@scinos scinos mentioned this issue Mar 2, 2021
Merged
@scinos scinos mentioned this issue Mar 17, 2021
Closed
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Mar 29, 2021
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 10, 2021
@simonhammes
Copy link
Contributor

I think this issue can be closed since it was fixed by #36244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@talldan @gziolo @mahnunchik @simonhammes @ZebulanStanphill