Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block refactor: Image size selector appears to have no effect when cropped images selected #29917

Closed
glendaviesnz opened this issue Mar 17, 2021 · 2 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Mar 17, 2021

Description

During testing of the Gallery refactor several people reported a bug of size selector not appearing to have any effect. When running the Gallery with Crop images toggled on the Image Size selector does not change the physical size of the image, only the quality of image loaded, ie. selecting thumbnail gives a blurry lower quality image rather than changing the dimensions, but if the image sizes are not radically different it appears to have no effect.

Step-by-step reproduction instructions

  • Check out the gallery refactor PR
  • Toggle on refactored gallery experiment
  • Add a new gallery with images
  • Toggle on 'Crop images'
  • Change sizes in Image Size selector

image-size

Expected behaviour

This is currently the same behaviour as the existing gallery block, so hard to know what should be expected here. Maybe the size selector should be removed when cropped images is toggled on, or the select options change to 'Image quality' in this context.

@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 17, 2021
@glendaviesnz
Copy link
Contributor Author

As this is existing behaviour in the gallery block and not a regression will defer this until after the first release of the refactored gallery

@glendaviesnz
Copy link
Contributor Author

Closing this in favour of #38050 as this is not specifically a gallery issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant