Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: Gallery caption rich text toolbar not dismissed on blur #29994

Closed
glendaviesnz opened this issue Mar 18, 2021 · 2 comments
Closed

Gallery block refactor: Gallery caption rich text toolbar not dismissed on blur #29994

glendaviesnz opened this issue Mar 18, 2021 · 2 comments
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

When the Gallery block is selected the caption rich text toolbar is shown. This toolbar remains visible if if caption field loses focus.

rt-toolbar
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 18, 2021
@glendaviesnz glendaviesnz mentioned this issue Apr 27, 2021
Merged
@glendaviesnz glendaviesnz self-assigned this Apr 28, 2021
@glendaviesnz
Copy link
Contributor Author

This will be mostly fixed by #31216 as with this fix in place the toolbar will only display if the caption is selected.

@glendaviesnz
Copy link
Contributor Author

Mostly fixed by #31216, toolbar still stays after editing caption and clicking on media placeholder but is dismissed if clicking on an image or deselecting block so good enough for now I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glendaviesnz