Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: selecting parent gallery does not show blue selection outline #29998

Closed
glendaviesnz opened this issue Mar 18, 2021 · 1 comment
Closed

Gallery block refactor: selecting parent gallery does not show blue selection outline #29998

glendaviesnz opened this issue Mar 18, 2021 · 1 comment
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Mar 18, 2021 •
edited
Loading

Description

Normally when select the parent of grouped blocs a blue outline is show around the selected block, this doesn't currently happen with the refactored gallery. It appears to be due to the fact the the caption rich text field immediately steals focus

Step-by-step reproduction instructions

  1. Check out gallery refactor PR and turn on refactored gallery experiment
  2. Add a new gallery block with images
  3. Select parent gallery block
  4. Notice the block is not outlined

Screenshots or screen recording (optional)

no-oultine
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 18, 2021
@glendaviesnz glendaviesnz mentioned this issue Mar 19, 2021
Closed
@glendaviesnz glendaviesnz reopened this Apr 26, 2021
@glendaviesnz glendaviesnz mentioned this issue Apr 27, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 27, 2021
@glendaviesnz
Copy link
Contributor Author

Fixed by #31216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glendaviesnz