Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templateLock attribute to core/cover. #30296

Closed
Locheed opened this issue Mar 26, 2021 · 2 comments
Closed

Add templateLock attribute to core/cover. #30296

Locheed opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@Locheed
Copy link

Locheed commented Mar 26, 2021

What problem does this address?

core/column and core/group did get the templateLock attribute. However, it would be good to have this option with other blocks too. e.g. core/cover. This block is awesome but cannot be really used on the client's site because it cannot be locked.

This however does work as a top-level block with inheriting templateLock from InnerBlocks. But now there does not have inheritance any more with core/columns > core/column > core/cover.

#26128

What is your proposed solution?

Add possibility to use the templateLock attribute directly with core/cover.

@talldan talldan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. labels Mar 29, 2021
@paaljoachim
Copy link
Contributor

General locking is being worked on these days.
Here is a Locking tracking issue:
On Locking and TemplateLocking
#29864

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 15, 2021
@Mamaduka
Copy link
Member

Fixed via #29916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants