Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSE] Update "Customize" link from Appearance > Theme page for block themes #30643

Closed
annezazu opened this issue Apr 8, 2021 · 7 comments
Closed
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement. [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 8, 2021

What problem does this address?

Currently, the customizer shouldn't be accessible when using a block theme. However, if you head to Appearance > Themes > Hover over current theme and you'll see the option to select "Customize" which will open the customizer:

Screen Shot 2021-04-08 at 4 50 22 PM

What is your proposed solution?

I think this should be updated to link to the Site Editor itself or the most appropriate section if it's a hybrid/universal theme.

cc @kjellr @carolinan in case this might actually be a TT1 blocks/theme specific issue!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels Apr 8, 2021
@aristath
Copy link
Member

aristath commented Apr 9, 2021

cc @kjellr @carolinan in case this might actually be a TT1 blocks/theme specific issue!

Not a TT1 issue, I can confirm this applies to all block-based themes.
I haven't looked at it, but maybe some things are just easier done in WP-Core instead of running in circles with filters from the plugin 😆

@jameskoster
Copy link
Contributor

Screenshot 2021-11-16 at 16 58 10

We need to update the big blue button here as well – it could link to Appearance > Editor when a block theme is active.

@noisysocks
Copy link
Member

I haven't looked at it, but maybe some things are just easier done in WP-Core instead of running in circles with filters from the plugin 😆

Yeah probably best to move this issue to Trac and fix it directly in Core.

@jameskoster
Copy link
Contributor

Trac ticket opened: https://core.trac.wordpress.org/ticket/54460

@jameskoster jameskoster added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label Nov 17, 2021
@mtias
Copy link
Member

mtias commented Nov 17, 2021

I expanded more about it in #36578, but it's not just updating the big blue button, it's about revising the welcome guide in the context of what the new features are — blocks, patterns, styles. Several of the side links could be modified as well (like menus).

@jameskoster
Copy link
Contributor

Oh I agree we should do all of that. But atm the the button(s) feel like a bug when you have a block theme active, and so perhaps warrant a dedicated effort?

@priethor priethor added the [Priority] High Used to indicate top priority items that need quick attention label Nov 17, 2021
@noisysocks
Copy link
Member

Thanks @jameskoster. Closing in favour of https://core.trac.wordpress.org/ticket/54460. Let's continue discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement. [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

No branches or pull requests

7 participants