Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken theme mods option #32511

Closed
grogou opened this issue Jun 8, 2021 · 4 comments
Closed

Broken theme mods option #32511

grogou opened this issue Jun 8, 2021 · 4 comments
Labels
[Block] Site Logo Affects the Site Logo Block

Comments

@grogou
Copy link

grogou commented Jun 8, 2021

Description

When activating Anyone can register option from wordpress settings, theme_mods options goes broken on db.
It's i guess can be with FSE.

Step-by-step reproduction instructions

  1. Activate some FSE theme for example TT1 Blocks theme.
  2. Go to General settings and activate Membership ( Anyone can register )

Screenshots or screen recording (optional)

image

WordPress information

  • WordPress version: 5.7.2
  • Gutenberg version: 10.7.4
@Sandstromer
Copy link

I had a similar issue that may be related.

Was trying out a membership plugin in conjunction with a FSE theme and all was working good before 10.7.3.

After updating Gutenberg to 10.7.4 (not 100% sure whether the error appeared in 10.7.3 or 10.7.4 as they were released very close together) I got the Warning: Illegal string offset 'custom_css_post_id' in ..\wp-includes\theme.php on line 1063 error.

Checking the options table showed the theme_mods_themeslug now had an option_value of "-", so I deleted that row and it was automatically re-added correctly, and all was good again.

Think it might be something to do with #32229 but not sure exactly how.

@Sandstromer
Copy link

Just to add that all my another installations that did not have any membership plugins nor the 'Anyone can register' option selected, were okay after updating to 10.7.4

@aristath
Copy link
Member

aristath commented Jun 9, 2021

This was a bug in a couple previous versions and it was fixed. @Sandstromer is right, this was due to changes in the site-logo block. #31994 is the PR that broke it, #32229 is the PR that fixed the issue.

@Mamaduka Mamaduka added the [Block] Site Logo Affects the Site Logo Block label Jun 9, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Jun 9, 2021

I think we can close this issue.

@grogou grogou closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block
Projects
None yet
Development

No branches or pull requests

4 participants