Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaneControl block triggers onChange event during mouseMove event when focused in safari #34965

Closed
snovosel opened this issue Sep 20, 2021 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Testing Needs further testing to be confirmed. [Package] Components /packages/components [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@snovosel
Copy link

Description

When working in safari browser (desktop), clicking the arrows within the RangeControl component will correctly trigger an onChange event, however subsequent mouseMove events above said RangeControl arrow elements will continue to trigger onChange events.

It looks like the RangeControl component ultimate renders an input of type number. I've looked and it doesn't seem that this is default behavior on Safari.

Step-by-step reproduction instructions

  1. Add any block that either uses a RangeControl component within its edit function or implements the component within the block's settings inspector. In my testing I've used the core/spacer block .

  2. In Safari, manipulate the Height in Pixels within the Block tab in the settings panel by clicking the arrows to the right of the number within the input.

  3. Observe the attributes are updated successfully

  4. Move the mouse up and down while remaining in the dimensions of the two arrows.

  5. Observe the attributes are continued to change without clicking anything.

Screenshots, screen recording, code snippet

No response

Environment info

  • Safari , Wordpress 5.8

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components Needs Testing Needs further testing to be confirmed. labels Sep 20, 2021
@stokesman stokesman added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Sep 21, 2021
@stokesman
Copy link
Contributor

Thanks for reporting this @snovosel. It seems like a duplicate of #32497 so I'll close it as such but do let me know if you think this is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Testing Needs further testing to be confirmed. [Package] Components /packages/components [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

3 participants