Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List v2 + RichText: allow trailing non editable content #41628

Open
ellatrix opened this issue Jun 9, 2022 · 0 comments
Open

List v2 + RichText: allow trailing non editable content #41628

ellatrix opened this issue Jun 9, 2022 · 0 comments
Labels
[Block] List Affects the List Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.

Comments

@ellatrix
Copy link
Member

ellatrix commented Jun 9, 2022

What problem does this address?

When nesting another list in a list item, this list is inserted inside the list item. Ideally this list item text should also be editable. To work around this, we wrapped the text in an editable div, but ideally we shouldn't have to do that.

The markup should look as follows:

<li contenteditable="true">
  some text
  <ul contenteditable="false">...</ul>
</li>

The current markup is this:

<li>
  <div contenteditable="true">
    some text
  </div>
  <ul>...</ul>
</li>

What is your proposed solution?

It will require modifying RichText so we can pass a before/after prop containing the element to render before or after the text.

@ellatrix ellatrix added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Block] List Affects the List Block labels Jun 9, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants