Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Heading element UI controls #41974

Closed
scruffian opened this issue Jun 27, 2022 · 5 comments · Fixed by #42176
Closed

Global Styles: Heading element UI controls #41974

scruffian opened this issue Jun 27, 2022 · 5 comments · Fixed by #42176
Assignees
@carolinan
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

Heading elements cannot be edited using the Global Styles UI.

What is your proposed solution?

It would be good to add heading elements to the list of elements that can be customized in the Global Styles UI:

Screenshot 2022-06-27 at 13 15 32

In addition, it would be good to have more granular control over heading (h1, h2, h3, h4, h5, h6) elements. Right now it's impossible to set rules for these elements via the UI, it can only be done via theme.json.

There is an older issue for when this was possible at a block level: #31695
@scruffian scruffian added Needs Design Needs design efforts. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 27, 2022
@mtias
Copy link
Member

mtias commented Jun 27, 2022

Headings should show up like this:

image

Within the panel you should be able to select a more granular h1-h6.

@scruffian
Copy link
Contributor Author

Thanks for the mockup @mtias

@scruffian
Copy link
Contributor Author

This is dependent on #41981

@carolinan carolinan self-assigned this Jul 5, 2022
@carolinan
Copy link
Contributor

Is there a design for the heading level selection?

@carolinan
Copy link
Contributor

A toggle group works pretty well?
(What I don't like is the mix of different font weights and capitalized texts)

Screen Shot 2022-07-06 at 08 23 34

@carolinan carolinan mentioned this issue Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Global Styles: Heading element UI controls WordPress/gutenberg
3 participants
@scruffian @mtias @carolinan