-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider not auto-publishing new templates #42130
Comments
Yeah this makes sense to me, as you say a simple change like this can easily break your site. |
So the only change to make is to not publish. Should a draft still be automatically saved? |
No I don't think that'd be the only change, we'd need to contemplate the publish flow, and consider drafts like you mentioned. But I think auto-publish is still worth discussing. It's awkward at the moment because:
But the former could easily be fixed, and the latter will be largely addressed by #42007. |
Brain storming... I create a template and it is automatically published. As templates can be made and also get more advanced. Auto publishing a template can break "something" on the site, as I have not yet done whatever remains for the template to work as it should. What about some kind of logic that does something like.... That could of course mean that there is somekind of publish panel for specific templates giving me the information I need to get the template correctly setup and published. |
Now that new templates are not created blank, the chance of breakages is significantly reduced making this less of an issue. Still, it would be nice if there was some visual feedback to confirm that templates are published immediately after creation. We can probably look into that separately. |
Currently, when you create a new template in the site editor it is published immediately, but there is no feedback to confirm this except for the disabled Save button which isn't particularly clear :)
template-created.mp4
This may be something to address in the mean time, but more importantly let's discuss whether templates should be published instantly like this, or require an additional user action.
A strong argument against auto-publishing is that the user may not understand the frontend of their site is affected immediately after creating the template. In the example video above I may leisurely go about creating my
tag
template over an extended period of time without realising that tag archives on the frontend could be broken until I'm done.cc @WordPress/gutenberg-design
The text was updated successfully, but these errors were encountered: