Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sibling inserter displays at the wrong time #44694

Closed
mtias opened this issue Oct 5, 2022 · 3 comments · Fixed by #44702
Closed

Sibling inserter displays at the wrong time #44694

mtias opened this issue Oct 5, 2022 · 3 comments · Fixed by #44702
Assignees
@youknowriad
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Oct 5, 2022

I've been meaning to report this for a while. Under some conditions — relatively easy to reproduce — the sibling inserter can be triggered by hovering over other elements, such as a template part, instead of the actual in-between blocks area in the site editor.

sibling-inserter-bug.mov
@mtias mtias added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Oct 5, 2022
@jasmussen
Copy link
Contributor

CC: @ramonjd, I think I recall you making a wonderful improvement to the sibling inserter a while back. Do you have any insights?

@ramonjd
Copy link
Member

ramonjd commented Oct 5, 2022

Now you're testing my memory.

I think you mean this PR from November 2021:

Is the bug that old? I wonder if something has changed in the meantime. cc @youknowriad just in case the recently-merged #44325 is related.

@jasmussen
Copy link
Contributor

That was the improvement I was thinking of, yes! As I recall, it greatly improved the inserter to appear more when you needed it, and it feels like it's regressed a bit. Thanks for the context.

@youknowriad youknowriad mentioned this issue Oct 5, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 5, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix insertion point showing up unexpectedly WordPress/gutenberg
5 participants
@youknowriad @mtias @jasmussen @ramonjd @priethor