Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a description field to theme.json style variations #44960

Closed
carolinan opened this issue Oct 14, 2022 · 0 comments · Fixed by #45242
Closed

Add a description field to theme.json style variations #44960

carolinan opened this issue Oct 14, 2022 · 0 comments · Fixed by #45242
Assignees
@carolinan
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

carolinan commented Oct 14, 2022 •
edited
Loading

What problem does this address?

Sometimes a name or title is not enough to describe the changes in a style variation. Especially if the user has a difficulty using the visual miniature preview.

What is your proposed solution?

Add an additional description field to the theme.json style variations.
The description would be used in the global styles sidebar, and for the preview of the style variations in the wordpress.org theme directory.
@andrewserong andrewserong added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. labels Oct 17, 2022
@carolinan carolinan mentioned this issue Oct 24, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 24, 2022
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling [Status] In Progress Tracking issues with work in progress labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a description key to theme.json style variations WordPress/gutenberg
3 participants
@carolinan @andrewserong @priethor