Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display block shortcuts in Top Bar when Inserter is open #45722

Closed
jameskoster opened this issue Nov 11, 2022 · 4 comments
Closed

Display block shortcuts in Top Bar when Inserter is open #45722

jameskoster opened this issue Nov 11, 2022 · 4 comments
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Extracted from #41379

When the Inserter is open, it could be nice to try replacing the document tools with shortcuts to insert common blocks. This will be most useful in situations where the Patterns tab is the default but you only want to insert a block.

It might be worth a little design exploration to work out details like animation, but that's probably a nice-to-have and needn't prohibit the creation of a PR.

@apeatling
Copy link
Contributor

apeatling commented Jan 26, 2023

The issue I see with this -- if you select the wrong pattern and insert it there would be no obvious undo button. I can imagine this being a problem for people. It's easy in this interface to click the wrong pattern -- or see it on the canvas and change your mind without an obvious path out.

@apeatling
Copy link
Contributor

I think having this, but also keeping the undo/redo buttons in place would be fine.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 26, 2023
@apeatling apeatling moved this from 💻 Needs development to 🏗 In progress in Gutenberg Phase 2: Customization Jan 26, 2023
@jameskoster
Copy link
Contributor Author

I think that could be okay, as long as there' some visual separation between the shortcuts and the undo/redo tools.

@youknowriad
Copy link
Contributor

I think given that the current inserter stays open as long as you keep it, we should discard this idea.
Also it's a bit of an a11y nightmare.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Gutenberg Phase 2: Customization Oct 24, 2024
@jameskoster jameskoster closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants