Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding links in Text Columns doesn't work when hitting Return key #4819

Closed
maddisondesigns opened this issue Feb 2, 2018 · 3 comments
Closed
Labels
[Type] Bug An existing feature does not function as intended

Comments

@maddisondesigns
Copy link

Issue Overview

When trying to add a link to the Text Columns block, if you simply type a URL and then hit the Return key, it doesn't work. It only works if you click the Apply icon.

gutenberg-textcolumnslinksdontwork

Steps to Reproduce (for bugs)

  1. Insert Text Columns block
  2. Add text to column
  3. Highlight some text and click the Link icon
  4. Type a url and hit your Return/Enter key

Expected Behavior

I should be able to simply hit Return/Enter after typing the URL

Current Behavior

Hitting Return/Enter after typing the URL doesn't work and the link is never added

Related Issues and/or PRs

#3709 - I've asked multiple times if you can please reopen this as it still breaks

Firefox Quantum 58.0.1 (64-bit)
WordPress 4.9.2
Gutenberg 2.1.0

@paulwilde
Copy link
Contributor

paulwilde commented Feb 2, 2018

I suspect this block type may get removed once nesting gets implemented. After all, the block is described as being experimental.

@maddisondesigns
Copy link
Author

I hope so because it's next to useless at the moment

@ajitbohra
Copy link
Member

Works as expected on master / v3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants