-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too many notifications shown when resetting customisations #49165
Comments
This is a duplicate of #46901 from my point of view. Mind closing out and deferring to the original? |
It's not a duplicate. This describes the problem of accumulating notifications about actions that a user does in one part of the UI and showing them all at once in an unrelated part of the UI. #46901 is about sequential actions producing one notification per action, which can be stacked or debounced. So no, don't close :) |
What do you see as the solution? In my mind, that aligns nicely with the currently open issue. The outcome feels the same to me (how best to display notifications) but perhaps I'm missing some nuance :D Will leave open either way but let's look at both at the same time. |
I think I discussed with @scruffian or @apeatling about reducing the time those snackbars stay on screen. Right now they linker for a long time. |
We should also clean up notifications when the context changes! |
In addition to reducing the snackbar time (it seems even a small reduction would help), it seems like we could also make a heuristic of showing no more than 3 or 4 at any one time, any more than that and the older ones disappear. Could perhaps even be 2 or 3. The way they work, they already steal focus away from the previous one, so for announcement purposes and to keep things from being too loud, there's really little incentive to keep the older ones around. Can even just have one timeout for the latest snackbar, and a very reduced timeout for older ones. |
Fixed by #50302 |
Although this fixed the mulitple notices appearing, they still reappear in some circumstances when moving between modes - another issue for this here. |
Description
When using the site editor to reset customisations to a few templates and template parts in a row:
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
really-updated.mp4
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: