Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many notifications shown when resetting customisations #49165

Closed
draganescu opened this issue Mar 17, 2023 · 9 comments
Closed

Too many notifications shown when resetting customisations #49165

draganescu opened this issue Mar 17, 2023 · 9 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Description

When using the site editor to reset customisations to a few templates and template parts in a row:

  1. immediately opening one will result in one top notification and one snackbar per reset template or template part
  2. there is a site updated snackbar that shows up just because I clicked manage templates
  3. there are stacked entity reverted notifications as well

Step-by-step reproduction instructions

  1. In a block theme
  2. Make modifications to three templates and one template part
  3. Using the site editor go to manage all templates and manage all template parts
  4. Reset each of the customized one
  5. Open a template
  6. Notice the notification Armageddon

Screenshots, screen recording, code snippet

really-updated.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@draganescu draganescu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 17, 2023
@annezazu
Copy link
Contributor

This is a duplicate of #46901 from my point of view. Mind closing out and deferring to the original?

@draganescu
Copy link
Contributor Author

It's not a duplicate. This describes the problem of accumulating notifications about actions that a user does in one part of the UI and showing them all at once in an unrelated part of the UI. #46901 is about sequential actions producing one notification per action, which can be stacked or debounced. So no, don't close :)

@annezazu
Copy link
Contributor

What do you see as the solution? In my mind, that aligns nicely with the currently open issue. The outcome feels the same to me (how best to display notifications) but perhaps I'm missing some nuance :D Will leave open either way but let's look at both at the same time.

@jasmussen
Copy link
Contributor

I think I discussed with @scruffian or @apeatling about reducing the time those snackbars stay on screen. Right now they linker for a long time.

@apeatling
Copy link
Contributor

Yes, there was a PR to reduce the time on screen here, that came along with some concerns. Happy to revisit that: #47199

I also opened a spin off that repositioned the snackbars. It's stalled currently on moving them to canvas only and out of the site editor chrome: #47298

@draganescu
Copy link
Contributor Author

We should also clean up notifications when the context changes!

@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Mar 22, 2023
@priethor priethor moved this from 🎨 Needs design to 💻 Needs development in Gutenberg Phase 2: Customization Apr 19, 2023
@priethor priethor added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Apr 19, 2023
@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label May 4, 2023
@jasmussen
Copy link
Contributor

In addition to reducing the snackbar time (it seems even a small reduction would help), it seems like we could also make a heuristic of showing no more than 3 or 4 at any one time, any more than that and the older ones disappear. Could perhaps even be 2 or 3. The way they work, they already steal focus away from the previous one, so for announcement purposes and to keep things from being too loud, there's really little incentive to keep the older ones around.

Can even just have one timeout for the latest snackbar, and a very reduced timeout for older ones.

@glendaviesnz
Copy link
Contributor

Fixed by #50302

@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization May 15, 2023
@glendaviesnz
Copy link
Contributor

Although this fixed the mulitple notices appearing, they still reappear in some circumstances when moving between modes - another issue for this here.

@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

6 participants