Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator: add exit animation #51499

Open
jameskoster opened this issue Jun 14, 2023 · 3 comments
Open

Navigator: add exit animation #51499

jameskoster opened this issue Jun 14, 2023 · 3 comments
Labels
Design System Issues related to the system of combining components according to best practices. [Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jun 14, 2023

For fun I was playing with animation values for the Navigator component and noticed a potential bug: the exit animation seems to be broken.

Take a look at the following video, where I slowed down the duration and tweaked the transform values to make the issue clearer:

navigator.mp4

When I click 'Pages', instead of the active 'Design' panel animating out of view, it disappears instantly. Likewise when I click back, the Pages panel disappears instantly.

It's not easy to spot on trunk as the duration for this animation is so low. But what is seen cannot be unseen 😆 Definitely not a high priority item, but I figured it was worth reporting.

cc @ciampo @mirka

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components [Feature] Navigation Component A navigational waterfall component for hierarchy of items. labels Jun 14, 2023
@mirka
Copy link
Member

mirka commented Jun 15, 2023

I'm guessing the motion.div needs to be wrapped in an AnimatePresence.

@ciampo
Copy link
Contributor

ciampo commented Jun 16, 2023

the exit animation seems to be broken.

Navigator has actually never supported exit animations 😃

We had a draft PR but we never iterated on it. I guess we could resume work on it at some point (and yes, as Lena suggested, we'd likely need to add AnimatePresence)

@ciampo ciampo changed the title Navigator: exit animation doesn't seem to work Navigator: add exit animation Jun 16, 2023
@jameskoster jameskoster added the Design System Issues related to the system of combining components according to best practices. label Sep 24, 2024
@auareyou auareyou moved this to Inbox 📥 in Design systems — Backlog Oct 7, 2024
@ciampo
Copy link
Contributor

ciampo commented Nov 25, 2024

Just stumbled upon this issue to say that Navigator now supports exit animations, as it's possible to see in the global styles sidebar.

The thing is, that since this PR was opened, the site editor's sidebar was migrated away from Navigator (from what I understand, due to some incompatibility between Navigator and the routing solution adopted for the site editor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Issues related to the system of combining components according to best practices. [Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
Status: 🔦 Needs triage
Development

No branches or pull requests

3 participants