Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DocumentActions to Style Revisions header #51667

Closed
1 of 2 tasks
richtabor opened this issue Jun 19, 2023 · 4 comments · Fixed by #62669
Closed
1 of 2 tasks

Add DocumentActions to Style Revisions header #51667

richtabor opened this issue Jun 19, 2023 · 4 comments · Fixed by #62669
Assignees
@creativecoder
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@richtabor
Copy link
Member

richtabor commented Jun 19, 2023 •
edited by creativecoder
Loading

Let's add the DocumentActions component to the header when style revisions are viewed.

  • Add DocumentActions to the header.
  • Update the "Global styles revisions" text to "Style revisions".
CleanShot 2023-06-19 at 17 53 22

Related issue for Style Book: #54514
@richtabor richtabor added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Jun 19, 2023
@richtabor
Copy link
Member Author

I ran into this when reviewing #51637

CleanShot 2023-06-19 at 17 56 09

@jasmussen
Copy link
Contributor

Good catch. We've referred to the feature as "global styles" (plural), and the inspector as "the style inspector". At any one time you're only looking at a single style. So should we have in the titlebar "Style revisions"? And in the command bar "Open style revisions"?

@jameskoster
Copy link
Contributor

"Style revisions" makes sense to me.

Should it also take on the 'command palette' appearance, and suggest the actions added in #51637?

Screenshot 2023-06-20 at 11 11 48

@richtabor richtabor mentioned this issue Jun 20, 2023
Merged
@richtabor
Copy link
Member Author

Should it also take on the 'command palette' appearance

Makes sense to use the title bar; style book could use it as well:

CleanShot 2023-06-20 at 09 32 27

@jordesign jordesign added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 18, 2023
@richtabor richtabor added this to Polish Sep 15, 2023
@richtabor richtabor moved this to Needs development in Polish Sep 15, 2023
@richtabor richtabor added the Needs Dev Ready for, and needs developer efforts label Sep 15, 2023
@richtabor richtabor mentioned this issue Sep 15, 2023
Closed
@richtabor richtabor changed the title Revisit the style revisions header label Add DocumentActions to Style Revisions header Sep 15, 2023
@Mamaduka Mamaduka mentioned this issue Mar 27, 2024
Closed
@Mamaduka Mamaduka mentioned this issue May 1, 2024
Merged
@creativecoder creativecoder mentioned this issue Jun 19, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Needs development to Done in Polish Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creativecoder creativecoder

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
Polish
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display the DocumentBar for Style Book and Style Revisions WordPress/gutenberg
5 participants
@jameskoster @jasmussen @creativecoder @richtabor @jordesign