Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: update block description based on sync status/optionality #51922

Closed
annezazu opened this issue Jun 26, 2023 · 4 comments · Fixed by #52010
Closed

Patterns: update block description based on sync status/optionality #51922

annezazu opened this issue Jun 26, 2023 · 4 comments · Fixed by #52010
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance

Comments

@annezazu
Copy link
Contributor

In testing 16.1 RC1 and the new pattern syncing, I noticed that the block description in the block settings sidebar reused (get it) what we had in place for reusable blocks. This doesn't take into account the new syncing status and needs to be updated:

Screen Shot 2023-06-26 at 8 49 18 AM

Here's the text:

Create and save content to reuse across your site. Update the block, and the changes apply everywhere it’s used.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Type] Copy Issues or PRs that need copy editing assistance [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jun 26, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 26, 2023
@bph bph added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Jun 26, 2023
@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jun 27, 2023
@glendaviesnz
Copy link
Contributor

I think this is actually correct as the only sort of Pattern block you can select in the editor is a synced one, ie. you will not see this decription for an unsynced pattern as unsynced patterns are never selectable in the editor canvas. @SaxonF what do you think?

@annezazu
Copy link
Contributor Author

Ah! I see. I wonder if we should call this "Synced Pattern" in that case or what can be done to make it clearer in the interface what the distinction is. I know these are details but they all add up to guide the user.

@talldan
Copy link
Contributor

talldan commented Jun 28, 2023

It'd be good to make sure there's design feedback on this before progressing.

Maybe it's better to show the pattern name instead of the block title, as is done for template parts?

@glendaviesnz
Copy link
Contributor

Maybe it's better to show the pattern name instead of the block title, as is done for template parts?

I like that idea, as essentially each of these is sort of a block in its own right. It would be nice to pull through the syncstatus as well if we can.

@priethor priethor moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.3.x Editor Tasks Jul 3, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.3.x Editor Tasks Jul 12, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants