Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons Blocks > link attributes rel values inconsistencies #53873

Open
Marc-pi opened this issue Aug 22, 2023 · 0 comments
Open

Social Icons Blocks > link attributes rel values inconsistencies #53873

Marc-pi opened this issue Aug 22, 2023 · 0 comments
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.

Comments

@Marc-pi
Copy link

Marc-pi commented Aug 22, 2023

Description

When Open in New Tab setting is active, the rel values are set to noopener nofollow

3 issues here :

  • the default value with target blank must be noreferer noopener
  • it is a non sense to apply the nofollow value (SEO wise) : it must be user's choice to use such a negative value (for crawlers)
  • when overidding the rel attributes value through the advanced setting, the rel value are cumulative, so there is no way to remove the nofollow value.

image

image

image

Solution : improve the link settings accordingly with the rework related to link component (after the 6.3 release)

see #53566
see #50891
ping @getdave / @richtabor / @ellatrix

Step-by-step reproduction instructions

  1. Just add the block within your template (ex: TT2/TT3)
  2. Activate the Open in New Tab setting
  3. Observe the source code

Environment info

  • TT3/TT3
  • WP 6.3
  • Gutenberg 16.4.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants