Font Library: Make the delete confirm dialog close immediatly after clicking 'Delete'

[afercia]

Description

When deleting an installed fonr and clicking 'Delete' in the confirm dialog, the confirm dialog stays open untile the font is actually deleted and the fonr library is refreshed.

This seems to be less than ideal for a few reasons>

• As the dialog stays open, users can click 'Delete' ultiple times, especially on a slow internet.
• By clicking multiple times, a new delete request is triggered, which leads to errors like the one in the screenshot below:

• Whatever teherror is, for example no internet connection, the confirm dialog stays open and the error notice appears behind the confirm dialog overlay. The actual error message is partially hidden. Depending on the size of the screen in use, the error may even be completely hidden. I'm not sure hiding error messages is a good user experience. Screenshot:

Step-by-step reproduction instructions

• Go to Site editor > Styles > Typography > Manage fonts.
• Install a Google font.
• Go to the Library tab and click the font you installed.
• Click 'Delete' at the bottom of the modal dialog. A confirm dialog opens.
• Quickly click 'Delete' multiple times.
• Observe an error message appears within the Fonts modal dialog, behind the confirm dialog overlay.
• Observe that after the font is actually deleted, the confirm dialog and the notice with the error messsage disappear.
• Note: for accessibility, when the confirm dialog closes, focus should be better handled. This is tracked in another issue.
• Install a new Google font.
• Go to the Library tab and click the font you installed.
• In your browser dev tools > Network, set your browseer to 'offline'.
• Click Delete and then Delete again in the confirm dialog.
• Observe the confirm dialog stays open.
• Observe an error message appears within the Fonts modal dialog, behind the confirm dialog overlay.
• Click Delete again. Observe the confirm dialog stays always open.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[afercia]

In a first moment I was thinking the simplest fix would be to set aria-disabled on the Delete button and noop it after the first click. That would prevent users from clicking more than once but it's not ideal. The confirm dialog would still stay open, fora fraction of second or indefinitely depending on the error type.

Thinking bdtter at this, I think that it's not expected for a confirm dialog to stay open i the first place. The very nature of a confirm dialog is to ask for a Yes or No. Once that answer has been given by the user, the confirm dialog should close immediately. Any other feedback like progress of the pending action, success or error, should be provided in the main UI and certainly not by keeping the confirm dialog open.

[matiasbenedetto]

Any other feedback like progress of the pending action, success or error, should be provided in the main UI and certainly not by keeping the confirm dialog open.

It seems in line with the changes added in #59036

2024-02-23.13-06-32.mp4