Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor > Pages: renaming shows old title in Inspector if you don't save #61292

Closed
annezazu opened this issue May 1, 2024 · 2 comments · Fixed by #61892
Closed

Site Editor > Pages: renaming shows old title in Inspector if you don't save #61292

annezazu opened this issue May 1, 2024 · 2 comments · Fixed by #61892
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented May 1, 2024

While testing GB 18.2 and some of the newer efforts, I noticed that if I rename the page via the page title, don't hit save, and then select the option to rename the page from the inspector, it shows the old title:

Changing.title.bug.mov

To replicate:

  1. Create a new page in the site editor.
  2. Edit the page title block and add a new title.
  3. Don't save.
  4. Select the three dot menu > rename in the Inspector.
  5. Notice the old name is in place.

cc @ntsekouras since you're working on this: #59689

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 1, 2024
@ntsekouras
Copy link
Contributor

ntsekouras commented May 2, 2024

The specific issue seems to have regressed from this PR: #60752. This highlights though the issue whether we should pass the edited entity or the saved one in these actions. For example duplicate post action suffers from the same thing.

This is a decision for all the actions, as they are handled in a single component. I'd say that the edited entity makes more sense in general, but would love more thoughts. --cc @jorgefilipecosta

Also noting that if we don't pass the edited entity this issue cannot be resolved.

@jorgefilipecosta
Copy link
Member

Using the edited entity makes sense I will prepare a PR that uses the edited entity it should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants