Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'name' attribute of 'details' block. #62251

Closed
sfadschm opened this issue Jun 3, 2024 · 4 comments · May be fixed by #56971
Closed

Add support for 'name' attribute of 'details' block. #62251

sfadschm opened this issue Jun 3, 2024 · 4 comments · May be fixed by #56971
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Type] Enhancement A suggestion for improvement.

Comments

@sfadschm
Copy link

sfadschm commented Jun 3, 2024

What problem does this address?

The details block is currently lacking support for its name attribute.

Spec.:
https://html.spec.whatwg.org/multipage/interactive-elements.html

The attribute is supported in all recent browsers (except Firefox, god knows why...):
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

While the "accordion-like" functionality supplied by the attribute might be misleading, the details block should still aim to support all HTML attributes defined in the spec, see also #21584 (comment)_.

What is your proposed solution?

Add the "name" attribute to the block settings.

@sfadschm sfadschm added the [Type] Enhancement A suggestion for improvement. label Jun 3, 2024
@t-hamano t-hamano added the [Block] Details Affects the Details Block - used to display content which can be shown/hidden label Jun 4, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Jun 4, 2024

Thanks for the report.

#56971 has been submitted to resolve this issue, but as you say, this attribute is not yet supported in Firefox, which is why the PR cannot be merged.

@sfadschm
Copy link
Author

sfadschm commented Jun 4, 2024

Oh, I do not understand how I did not find these in the search, sorry...
Thanks for linking the PR.

@dogee
Copy link

dogee commented Oct 31, 2024

@t-hamano Just a reminder that Firefox finally added the support for name attribute in its 130 version released in September.
So I think the #56971 can be merged ASAP.

Thanks for your understanding.

@t-hamano
Copy link
Contributor

t-hamano commented Jan 8, 2025

Closing as duplicate of #56969.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants