Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed blocks: figcaption inserted via toolbar not nested within figure element #64960

Closed
2 tasks done
frkly opened this issue Aug 31, 2024 · 2 comments
Closed
2 tasks done

Embed blocks: figcaption inserted via toolbar not nested within figure element #64960

frkly opened this issue Aug 31, 2024 · 2 comments
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended

Comments

@frkly
Copy link

frkly commented Aug 31, 2024

Description

Feature 'Embed Block caption' is not working properly. I expect the figcaption to be output as a child element of the figure, but it is currently being inserted as a sibling element after the figure instead.

Step-by-step reproduction instructions

  1. Install Gutenberg version 19.1.0.
  2. Open Gutenberg and paste a YouTube video URL into the visual editor.
  3. Add a figcaption via the toolbar.
  4. Inspect the figcaption using Chrome Dev Tools. You'll see that the figcaption is placed outside of the figure element.
8c22f489ab395e97286c6b88a111ff47

Screenshots, screen recording, code snippet

c208e6b82ccd707d28d5d5ae607f56d1.mp4

Environment info

  1. Gutenberg version 19.1.0
  2. WordPress 6.6.1
  3. Chrome 128.0.6613.86(Official Build)
  4. Windows 11

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@frkly frkly added the [Type] Bug An existing feature does not function as intended label Aug 31, 2024
@t-hamano t-hamano added the [Block] Embed Affects the Embed Block label Sep 1, 2024
@hbhalodia hbhalodia mentioned this issue Sep 2, 2024
Merged
@hbhalodia
Copy link
Contributor

Hi @frkly @t-hamano, I have raised the PR to fix the same - #64970.

Thank You,

@t-hamano
Copy link
Contributor

Fixed by #64970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t-hamano @hbhalodia @frkly